Draft
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2854 +/- ##
==========================================
+ Coverage 49.21% 50.94% +1.73%
==========================================
Files 112 112
Lines 4844 4844
Branches 1343 1343
==========================================
+ Hits 2384 2468 +84
+ Misses 2456 2372 -84
Partials 4 4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…m/OriginProtocol/origin-dollar into sparrowDom/automated-actions-lite-chris2
railway-app
bot
temporarily deployed
to
reasonable-success / production
- Add TypeScript, ESLint TS, and Prettier TS support to contracts/ - Create action() registration pattern for hardhat tasks with Winston logging - Convert 13 Defender actions to self-registering TS hardhat tasks - Add Loki transport for centralized logging - Add healthcheck task for validation - Fix ssv-scanner dependency (bloxapp → ssvlabs) - Fix @lodestar/types ESM compatibility via ts-node skipProject
…om/automated-actions-lite
- Replace console logging with winston/Loki logger in supervisor - Delete log-events.ts emit wrappers, inline structured logging in action.ts - Extract HTTP API + run tracking into api.ts, slim supervisor to orchestrator - Add action.start/action.success events to action framework - Generate run_id (UUID) per action, remove AUTOMATON_RUN_ID env var - Add real action.test.ts that exercises createActionHandler() with mock signer - Delete stale test-action.ts, action-runner.test.ts, snapshot
…ion (#2876) * Add shared Postgres nonce queue for cross-repo transaction serialization Both origin-dollar and arm-oeth cron containers use the same KMS signer, risking nonce collisions when transactions are sent concurrently. This adds a Postgres-backed nonce lock that wraps the signer transparently via SELECT ... FOR UPDATE, holding the row lock for the full tx lifecycle. - nonceQueue.ts: withNonceLock + wrapWithNonceQueue signer wrapper - action.ts: conditionally wraps signer when DATABASE_URL is set - docker-compose.yml: adds postgres service for local dev - cron-supervisor.ts: pool cleanup on shutdown - Includes integration tests verifying lock serialization * add comment * add timeout mechanism * add functionality to replace transaction with higher gas and rebroadcast transaction * add github tests for the nonce locking mechanism * add lifecycle tests * fix lint * add maximum gas price spending caps per chain --------- Co-authored-by: Christopher Jacobs <apexearth@gmail.com>
…ses issued by the automated actions module
…ow a flag to differentiate between Winston contextualized logs and old way of logs
…ed to all logs. Also fix issue where Grafana wouldn't receive most of emitted logs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces a cron runtime supervisor for the Docker deployment that:
supercronicscheduling from JSON configAWS KMS Signer Usage
Cron/manual actions still execute existing Hardhat tasks, so signer behavior is unchanged and continues to use the repo signer selection logic:
AWS_ACCESS_KEY_IDandAWS_SECRET_ACCESS_KEYare present, the task path selects AWS KMS signing.DirectKmsTransactionSigner(purrikey) with the configured relayer key id and region.utils/txLogger), so run-level tx IDs are visible in container logs/Loki.Cronjobs Configured via JSON
Cron configuration is now JSON-first:
contracts/cron/cron-jobs.jsonname(string)schedule(5-field cron expression)enabled(boolean)command(string)/etc/cronjob(with# <name>comments) and started viasupercronic.Cronjobs Triggered via API
A lightweight Node HTTP server is started with the container runtime and runs alongside
supercronic./api/v1/*ACTION_API_BEARER_TOKEN(required)POST /api/v1/actions/:name/runs202 Acceptedwith:runIdactionstatusstatusUrlstartedAtLocationheader pointing to run status URLqueued -> running -> succeeded|failed)enabled=false500)Cron Configuration / Run Status via API
GET /api/v1/actionsname,schedule,enabledGET /api/v1/runs/:runIdstatusstartedAtfinishedAtexitCodesignalGET /healthz(no auth)supercronicis runningRuntime Notes
node /app/scripts/cron-supervisor.js).HOST(default0.0.0.0)PORT(default8080)ACTION_RUN_HISTORY_LIMIT(default500)ACTION_WORKDIR(default/app)